SDK - Tx Storage & Ark SDK func update #320
Open
+1,499
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cli fix config
- Add listenForVtxos function to poll server for new VTXOs - Implement listenToVtxoChan to process and insert VTXOs and transactions - Handle both spendable and spent VTXOs, as well as boarding transactions - Use goroutines and channels for asynchronous processing - Add error handling and logging for better debugging
|
is the title correct? Only touches the covenant version? We should mention a new big feature like adding a SQLite storage. Also how that will impact WASM wrapper? |
sekulicd
changed the title
|
@sekulicd we made some changes to covenant's GetTransactionHistory() yesterday. |
altafan
requested changes
Sep 20, 2024
altafan
reviewed
Sep 20, 2024
| explorer explorer.Explorer | ||
| client client.ASPClient | ||
|
|
||
| vtxosChan chan map[spent]client.Vtxo |
There was a problem hiding this comment.
can you explain why map[spent]client.Vtxo?
altafan
reviewed
Sep 20, 2024
Comment on lines
+157
to
+175
| func (a *arkClient) ListVtxos( | ||
| ctx context.Context, | ||
| ) (spendableVtxos, spentVtxos []client.Vtxo, err error) { | ||
| offchainAddrs, _, _, err := a.wallet.GetAddresses(ctx) | ||
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| for _, addr := range offchainAddrs { | ||
| spendable, spent, err := a.client.ListVtxos(ctx, addr) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| spendableVtxos = append(spendableVtxos, spendable...) | ||
| spentVtxos = append(spentVtxos, spent...) | ||
| } | ||
|
|
||
| return | ||
| } |
There was a problem hiding this comment.
after syncing with master this must be dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds storage for transactions and vtxos into SDK sqlite storage.
This refactors ark sdk api by adding GetTransactionEventChannel which can be used to listen for new events, it replaces PaymentNotification that was discussed before, this to be closed.
It also updates GetTransactionHistory to read txs from db.
Main idea is to add listenForVtxos function that polls the server every 1(or smtn diff) seconds for new VTXOs,
Func listenToVtxoChan will listen for new vtxos and with help of current state in db will create tx history by using existing
vtxosToTxsCovenant/vtxosToTxsCovenantless funcs.
I pushed changes to the same PR in which i emphasised potential bug in how we handle covenant transaction history, PSB:
@bordalix let me know if u agree that this is bug.
@tiero @louisinger @bordalix @altafan please review.