[SDK] Add Transaction History (#288)

* tx history * fix * fix * pr review refactor * pr review refactor * fix * pr review refactor * exclude gosec G115 Integer Overflow Conversion * ignore some gosec errs * ignore some gosec errs * ignore createdat in test assertion * Fixes (#7) * Fixes * Fixes * Update golang (#8) * update gha golangci-lint version * update gha golangci-lint version * fix linting issues * fix linting issues * fix linting issues * add linter timeout --------- Co-authored-by: Pietralberto Mazza <[email protected]>
ark-network · Sep 10, 2024 · a8cf0ed · a8cf0ed
1 parent 4da76ec
commit a8cf0ed
Show file tree

Hide file tree

Showing 22 changed files with 830 additions and 40 deletions.
diff --git a/.github/workflows/ark.unit.yaml b/.github/workflows/ark.unit.yaml
@@ -47,14 +47,15 @@ jobs:
           go-version: '>=1.22.6'
       - uses: actions/checkout@v3
       - name: check linting
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54
+          version: v1.61
           working-directory: ./server
+          args: --timeout 5m
       - name: check code integrity
         uses: securego/gosec@master
         with:
-          args: "-severity high -quiet ./..."
+          args: "-severity high -quiet -exclude=G115 ./..."
       - run: go get -v -t -d ./...
       - name: unit testing
         run: make test
@@ -71,14 +72,15 @@ jobs:
           go-version: '>=1.22.6'
       - uses: actions/checkout@v3
       - name: check linting
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54
+          version: v1.61
           working-directory: ./pkg/client-sdk
+          args: --timeout 5m
       - name: check code integrity
         uses: securego/gosec@master
         with:
-          args: "-severity high -quiet ./..."
+          args: "-severity high -quiet -exclude=G115 ./..."
       - run: go get -v -t -d ./...
       - name: unit testing
         run: make test
diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,5 @@
 # First image used to build the sources
-FROM golang:1.21.0 AS builder
+FROM golang:1.23.1 AS builder
 
 ARG VERSION
 ARG TARGETOS
@@ -14,7 +14,7 @@ RUN cd server && CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} go build -l
 RUN cd client && CGO_ENABLED=0 GOOS=${TARGETOS} GOARCH=${TARGETARCH} go build -ldflags="-X 'main.Version=${VERSION}'" -o ../bin/ark .
 
 # Second image, running the arkd executable
-FROM alpine:3.18
+FROM alpine:3.20
 
 RUN apk update && apk upgrade
 

diff --git a/buf.Dockerfile b/buf.Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.21-alpine3.18 as builder
+FROM golang:1.23.1-alpine3.20 as builder
 
 RUN apk add --no-cache git
 

diff --git a/client/go.mod b/client/go.mod
@@ -1,6 +1,6 @@
 module github.com/ark-network/ark/client
 
-go 1.22.6
+go 1.23.1
 
 replace github.com/ark-network/ark/common => ../common
 

diff --git a/client/utils/cypher.go b/client/utils/cypher.go
@@ -80,6 +80,7 @@ func (c *cypher) decrypt(encrypted, password []byte) ([]byte, error) {
 		return nil, err
 	}
 	nonce, text := data[:gcm.NonceSize()], data[gcm.NonceSize():]
+	// #nosec G407
 	plaintext, err := gcm.Open(nil, nonce, text, nil)
 	if err != nil {
 		return nil, fmt.Errorf("invalid password")

diff --git a/common/go.mod b/common/go.mod
@@ -1,6 +1,6 @@
 module github.com/ark-network/ark/common
 
-go 1.22.6
+go 1.23.1
 
 replace github.com/btcsuite/btcd/btcec/v2 => github.com/btcsuite/btcd/btcec/v2 v2.3.3
 

diff --git a/go.work b/go.work
@@ -1,4 +1,4 @@
-go 1.22.6
+go 1.23.1
 
 use (
 	./api-spec

diff --git a/pkg/client-sdk/ark_sdk.go b/pkg/client-sdk/ark_sdk.go
@@ -27,6 +27,7 @@ type ArkClient interface {
 	SendAsync(ctx context.Context, withExpiryCoinselect bool, receivers []Receiver) (string, error)
 	Claim(ctx context.Context) (string, error)
 	ListVtxos(ctx context.Context) ([]client.Vtxo, []client.Vtxo, error)
+	GetTransactionHistory(ctx context.Context) ([]Transaction, error)
 }
 
 type Receiver interface {

diff --git a/pkg/client-sdk/client.go b/pkg/client-sdk/client.go
@@ -303,3 +303,7 @@ func getWalletStore(storeType, datadir string) (walletstore.WalletStore, error)
 		return nil, fmt.Errorf("unknown wallet store type")
 	}
 }
+
+func getCreatedAtFromExpiry(roundLifetime int64, expiry time.Time) time.Time {
+	return expiry.Add(-time.Duration(roundLifetime) * time.Second)
+}