Histograms precache #509
Histograms precache #509
Conversation
|
This is great, definitely shows very nice performance once loaded! I am getting a lot of CPU usage and girder seems slow even after progress bar says "Optimized and fully loaded". I'm assuming the histogram caching is running then. Is it possible to show a progress bar for that as well? Whatever it is, there is some process running on Girder that seems to take up CPU for a LONG time after and makes Girder a bit sluggish. Also, the overview panel seems to load from the full image, so only shows once that is loaded. I've noticed now that the tile_cache can load much faster, but doesn't show up in the overview panel. One could consider using the tile_cache for the overview panel, but I don't think it's super important, just a note. This is on my laptop because I'm at home today (holiday, technically), but I'll also test this on my server at work tomorrow morning. |
Enable listening to the same job several times in the job store
There was a problem hiding this comment.
@bruyeret Generally looks good, but I have a question. Right now, the progress bar shows from the very beginning. Is it actually running at the same time as the tile caching? Or is it scheduled to wait until after the tile_cache to begin computation? If it is scheduled to compute after the tile_cache, is it hard to make the progress bar only start once is actually starts computing? If it is a pain to do, then this is fine as it is!
|
Histogram caching runs after tile caching but it the progress bar is displayed even if the job is inactive |
|
It's done! But there is a small time between tile caching and histogram caching when the frontend thinks that everything is cached because histogram caching has not started yet |
|
Looks great to me, thank you! |
|
LGTM |
To be merged after the overview PR #507
Close #502