-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tokens and tree struct to support loops and conditionals #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll keep this PR in draft but split it into more PRs.
After these modules are implemented, we can exclude the following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
:if
,:case
and:for
directives.:if
and:case
are conditionals and cannot be used together, the consumer should use one or another.:for
is a loop directive and can be used with a conditional.Example:
The compiled template:
We have a simple, compact, and powerful template.
Why this and not implement it in pure Erlang?
The implementation of this PR provides a clear understanding of the consumer's intent. Given the flexible nature of the Erlang code, we must traverse the AST to accurately determine the consumer's objectives, and that's not so easy.
We must definitely provide the same functionality by writing Erlang code. However, for now, this "shortened" version addresses some important gaps in Arizona's templates.
Also, this PR changes our scanner, parser, and compiler, but just a bit:
I haven't implemented the diff for the new struct yet. Due to the new loop rendering, I'll also need to change the JS code a bit.
The behavior of the diff patch remains the same even for loops and conditionals.
Important
I've removed some tokens concat to simplify the understanding and the development, e.g.:
We can improve this in another PR.
Note
Closes #17, closes #18, closes #19.