Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda Node 20.x Support #147

Merged
merged 5 commits into from
Jan 11, 2025

Conversation

mylesboone
Copy link
Contributor

@mylesboone mylesboone commented Oct 19, 2023

Lambda Node 18.x and 20.x runtimes come with AWS SDK v3.
This upgrades the use to AWS SDK v3.
@arithmetric Not sure how you manage versions of this gem, but this is incompatible with Lambda Node 16.x runtime.

@mylesboone
Copy link
Contributor Author

@arithmetric do you need anything further on this?

index.js Show resolved Hide resolved
@lucky81
Copy link

lucky81 commented Dec 28, 2023

This update introduced an error for me as my S3 bucket is in a different region to my Lambda. The following fixed it:
overrides.s3 : new S3Client({region: "eu-west-2", signatureVersion: 'v4'})

@mylesboone mylesboone changed the title AWS Lambda Node 18.x Support AWS Lambda Node 20.x Support Jan 21, 2024
@mylesboone
Copy link
Contributor Author

This now uses SES v2, which supports emails up to 40mb.

@nastevens
Copy link

Just updated with this version alongside an update to Node 20. Seems to be working great!

@mylesboone mylesboone mentioned this pull request May 4, 2024
@mylesboone
Copy link
Contributor Author

Hey @arithmetric, it seems a lot of folks are getting hung up because the master branch will no longer work out of the box with AWS Lambda. Would you be able to take a look at this and merge if able? Also if you need more eyes/help on this repo let me know. I would be willing to help maintain.

@anandcdas
Copy link

Hi @arithmetric, we will have to update this repo as AWS Lambda will stop its support for Node.js 16 by June 12, 2024.

@mylesboone Thanks for your help. Much appreciated.

@GatienBoquet
Copy link

@arithmetric Hello can you accept this PR :)

@dkavanagh
Copy link

I've taken this version into my codebase. I wish it could be merged instead!

@arithmetric
Copy link
Owner

Thanks for this contribution (and for the patience for a review)!

I'm going to make some other maintenance changes, like updating dependencies, and then will publish a release.

@arithmetric arithmetric merged commit 7fd0c6c into arithmetric:master Jan 11, 2025
*
* @param {object} data - Data bundle with context, email, etc.
*
* @return {object} - Promise resolved with data.
*/
exports.sendMessage = function(data) {
var params = {
Destinations: data.recipients,
Source: data.originalRecipient,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid any functional changes, I'll restore this Source parameter.

@mylesboone mylesboone deleted the node18support branch January 11, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants