-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Lambda Node 20.x Support #147
Conversation
a0bb33f
to
dbf70d7
Compare
dbf70d7
to
f677975
Compare
@arithmetric do you need anything further on this? |
This update introduced an error for me as my S3 bucket is in a different region to my Lambda. The following fixed it: |
29bca3d
to
f8575bb
Compare
4fea704
to
e6b8674
Compare
This now uses SES v2, which supports emails up to 40mb. |
Just updated with this version alongside an update to Node 20. Seems to be working great! |
Hey @arithmetric, it seems a lot of folks are getting hung up because the master branch will no longer work out of the box with AWS Lambda. Would you be able to take a look at this and merge if able? Also if you need more eyes/help on this repo let me know. I would be willing to help maintain. |
Hi @arithmetric, we will have to update this repo as AWS Lambda will stop its support for Node.js 16 by June 12, 2024. @mylesboone Thanks for your help. Much appreciated. |
@arithmetric Hello can you accept this PR :) |
I've taken this version into my codebase. I wish it could be merged instead! |
Thanks for this contribution (and for the patience for a review)! I'm going to make some other maintenance changes, like updating dependencies, and then will publish a release. |
* | ||
* @param {object} data - Data bundle with context, email, etc. | ||
* | ||
* @return {object} - Promise resolved with data. | ||
*/ | ||
exports.sendMessage = function(data) { | ||
var params = { | ||
Destinations: data.recipients, | ||
Source: data.originalRecipient, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid any functional changes, I'll restore this Source
parameter.
Lambda Node 18.x and 20.x runtimes come with AWS SDK v3.
This upgrades the use to AWS SDK v3.
@arithmetric Not sure how you manage versions of this gem, but this is incompatible with Lambda Node 16.x runtime.