Use internal build version for release SWIs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Software image version for release SWIs only contains the version and not the changenum.
src/pytest_netdut/factories.py
Outdated
| @@ -163,7 +163,14 @@ def _os_version(request): | |||
| ssh = request.getfixturevalue(f"{name}_ssh") | |||
| assert ssh.cli_flavor in {"eos", "mos"} | |||
| output = ssh.sendcmd("show version", timeout=300) | |||
| matcher = re.search(r"Software image version: (\S*)", output) | |||
| if ssh.cli_flavor == "mos": | |||
| matcher = re.search(r"Software image version: (\S*)", output) | |||
There was a problem hiding this comment.
matcher sounds like a compiled regex. Can we call it match instead?
romecode
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Software image version for release SWIs only contains the version and not the changenum.