Feat(eos_cli_config_gen): Added login/motd banner in device documentation #4855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4855
# Activate the virtual environment
source test-avd-pr-4855/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4644#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4644 --force
# Optional: Install AVD examples
cd test-avd-pr-4855
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
Vibhu-gslab
approved these changes
Jan 9, 2025
Vibhu-gslab
force-pushed
the
issue-4644
branch
from
492aa30 to
0993d6c
Compare
gmuloc
reviewed
Jan 9, 2025
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Jan 10, 2025
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/banners.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/banners.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Jan 10, 2025
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host2.md
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Jan 10, 2025
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host2.md
Outdated
Show resolved
Hide resolved
gmuloc
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added login/motd banner in device documentation.
Related Issue(s)
Fixes #4644
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Added login/motd banner in device documentation.
How to test
Run molecule
Checklist
User Checklist
Repository Checklist