Feat(eos_designs): Enable evpn_gateway for pathfinder deployment #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4831
# Activate the virtual environment
source test-avd-pr-4831/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/aristanetworks/avd.git@evpngw_final#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/aristanetworks/avd.git#/ansible_collections/arista/avd/,evpngw_final --force
# Optional: Install AVD examples
cd test-avd-pr-4831
ansible-playbook arista.avd.install_examples |
ayushmittal-arista
force-pushed
the
evpngw_final
branch
from
b362187 to
6622361
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ayushmittal-arista
force-pushed
the
evpngw_final
branch
2 times, most recently
from
6622361 to
7a95deb
Compare
gmuloc
reviewed
Jan 2, 2025
Comment on lines
+87
to
+89
| # Enable gateway when evpn_gateway is enabled | ||
| # - for ebgp | ||
| # - for ibgp, currently supported only for pathfinder deployment. |
There was a problem hiding this comment.
can be moved to the docstring
gmuloc
reviewed
Jan 2, 2025
| @@ -9,7 +9,7 @@ | |||
| from typing import TYPE_CHECKING | |||
|
|
|||
| from pyavd._errors import AristaAvdError, AristaAvdInvalidInputsError | |||
| from pyavd._utils import default | |||
| from pyavd._utils import default, get | |||
There was a problem hiding this comment.
looks get is not needed in your change
gmuloc
reviewed
Jan 2, 2025
| @@ -309,6 +309,7 @@ ip extcommunity-list ECL-EVPN-SOO permit soo 192.168.255.1:0 | |||
| ! | |||
| ip prefix-list PL-LOOPBACKS-EVPN-OVERLAY | |||
| seq 10 permit 192.168.255.0/24 eq 32 | |||
| seq 20 permit 192.168.42.0/24 eq 32 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Allow configuring evpn_gateway on wan_router
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
No changes to data model.
Code Changes:
We also additionally generate config on peer side of remote gateway.
How to test
molecule
Checklist
User Checklist
Repository Checklist