Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): update feature support - 7358 #4810

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

colinmacgiolla
Copy link
Contributor

Change Summary

Update the platform settings for the 7358 as we now support BGP update_wait_install

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Default parameter update

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4810
# Activate the virtual environment
source test-avd-pr-4810/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/colinmacgiolla/ansible-avd.git@update-7358#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/colinmacgiolla/ansible-avd.git#/ansible_collections/arista/avd/,update-7358 --force
# Optional: Install AVD examples
cd test-avd-pr-4810
ansible-playbook arista.avd.install_examples

@gmuloc
Copy link
Contributor

gmuloc commented Dec 12, 2024

Hi @colinmacgiolla thanks for the PR! Your description mentions

as we now support BGP update_wait_install

What does it mean from the point of view of support? Is it starting after some EOS version? (if so which one?) Essentially could introducing this change mean that suddenly we would start generated configuration that would break on already deployed routers because "they don't yet support" BGP update_wait_install?

@ClausHolbechArista
Copy link
Contributor

I think this will have to be postponed until 6.0 so we can warn users in the porting guide.

@gmuloc gmuloc added this to the v6.0.0 milestone Jan 6, 2025
@gmuloc gmuloc marked this pull request as draft January 6, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants