Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Support for L3 Inband ZTP #4304

Open
wants to merge 12 commits into
base: devel
Choose a base branch
from

Conversation

jrecchia1029
Copy link
Contributor

Change Summary

Adding L3 In band ZTP functionality

Component(s) name

arista.avd.eos_designs

Proposed changes

Enable L3 In Band ZTP by making the network device upstream of the ZTP a dhcp server that will allocate the appropriate IP address on the connected p2p interface.

How to test

Updated eos_designs_unit_tests for the INBAND_MGMT_TESTS group

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4304
# Activate the virtual environment
source test-avd-pr-4304/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/jrecchia1029/ansible-avd.git@l3_inband_ztp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/jrecchia1029/ansible-avd.git#/ansible_collections/arista/avd/,l3_inband_ztp --force
# Optional: Install AVD examples
cd test-avd-pr-4304
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 31, 2024
@jrecchia1029 jrecchia1029 changed the title initial l3 inband ztp commit Feat(eos_designs): Support for L3 Inband ZTP Aug 1, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role module: inventory_to_container issue related to inventory_to_container module module: configlet_build_config issue related to configlet_build_config module filter: is_in_filter issue related to is_in_filter plugin filter: list_compress issue related to list_compress filter plugin filter: natural_sort issue related to natural_sort filter plugin type: code quality CI and development toolset role: eos_validate_state role: dhcp_provisioner state: Documentation role Updated type: Python filters role: eos_designs issue related to eos_designs role labels Aug 14, 2024
@github-actions github-actions bot removed type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role module: inventory_to_container issue related to inventory_to_container module module: configlet_build_config issue related to configlet_build_config module filter: is_in_filter issue related to is_in_filter plugin filter: list_compress issue related to list_compress filter plugin labels Aug 14, 2024
Copy link

github-actions bot commented Oct 3, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added state: conflict PR with conflict state: Documentation role Updated role: eos_designs issue related to eos_designs role and removed state: conflict PR with conflict labels Oct 3, 2024
Copy link

sonarcloud bot commented Oct 3, 2024

Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista
Copy link
Contributor

Please rebase and resolve conflicts

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Nov 13, 2024
Copy link

sonarcloud bot commented Nov 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants