test: Add integration tests for scripts in ANTA documentation #1011
+188
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmuloc
changed the title
mtache
requested changes
Jan 17, 2025
| @@ -342,3 +342,33 @@ async def connect_inventory(self) -> None: | |||
| if isinstance(r, Exception): | |||
| message = "Error when refreshing inventory" | |||
| anta_log_exception(r, message, logger) | |||
|
|
|||
| def dump(self, path: Path) -> None: | |||
There was a problem hiding this comment.
The AntaCatalog class has a dump() function that has a different signature and doing different stuff.
Let's aggree on an equivalent signature for the dump(), yaml(), and json() functions.
Same for the ResultManager it is another dump() function returning a dict...
There was a problem hiding this comment.
yeah not sure why I added this - this is a PR from a couple of months ago :p will need to re read
| try: | ||
| with path.open("w", encoding="UTF-8") as file: | ||
| safe_dump( | ||
| {AntaInventory.INVENTORY_ROOT_KEY: {"hosts": [safe_load(host.model_dump_json(serialize_as_any=True, exclude_unset=True)) for host in hosts]}}, |
There was a problem hiding this comment.
Maybe get rid of INVENTORY_ROOT_KEY and write the right pydantic model?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #831
Checklist:
pre-commit run)tox -e testenv)