Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(highlight): only highlight source code when supported #10

Merged
merged 1 commit into from
May 11, 2024

Conversation

arikkfir
Copy link
Owner

@arikkfir arikkfir commented May 11, 2024

This change ensures that we only highlight caller source code when:

  1. It is enabled
    • By default, highlighting is enabled
    • Can be disabled by setting JUSTEST_DISABLE_SOURCE_HIGHLIGHT to a "falsy" value like false, FALSE, False, 0, or f
  2. Supported
    • Currently only macOS is supported, because dark-mode detection is only supported on macOS
    • Dark mode detection succeeded (again, currently only on macOS)

This change ensures that we only highlight caller source code when:

1. It is enabled
   - By default, highlighting is enabled
   - Can be disabled by setting "JUSTEST_DISABLE_SOURCE_HIGHLIGHT" to a
     falsy value like "false", "FALSE", "False", "0", or "f"
2. Supported
   - Currently only macOS is supported, because dark-mode detection is
     only supported on macOS
   - Dark mode detection succeeded (again, currently only on macOS)
@arikkfir arikkfir added the bug Something isn't working label May 11, 2024
@arikkfir arikkfir self-assigned this May 11, 2024
@arikkfir arikkfir merged commit 4815530 into main May 11, 2024
2 checks passed
@arikkfir arikkfir deleted the fix/highlight-source-code-only-when-supported branch May 11, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant