internal/controller: generate hash of declarative flow by using "schema inspect" #253
+52
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdao
force-pushed
the
d/custom-atlas-config
branch
3 times, most recently
from
6cc9702 to
86989ea
Compare
datdao
force-pushed
the
d/custom-atlas-config
branch
from
86989ea to
cb035b4
Compare
giautm
reviewed
Jan 8, 2025
| // Calculate the hash of the current schema. | ||
| hash, err := cli.SchemaInspect(ctx, &atlasexec.SchemaInspectParams{ | ||
| Env: data.EnvName, | ||
| URL: "env://schema.src", |
There was a problem hiding this comment.
This may not correct, the user can define the src in the env block.
env {
src = "file://schema.hcl"
}
giautm
reviewed
Jan 8, 2025
| hash, err := cli.SchemaInspect(ctx, &atlasexec.SchemaInspectParams{ | ||
| Env: data.EnvName, | ||
| URL: "env://schema.src", | ||
| Format: `{{ .Hash | base64url }}`, |
There was a problem hiding this comment.
Maybe just use the raw .Hash. base64url is used for schema's tag.
giautm
reviewed
Jan 8, 2025
Comment on lines
+836
to
+837
| schema := envBody.AppendNewBlock("schema", nil).Body() | ||
| schema.SetAttributeValue("src", cty.StringVal(d.Desired.String())) |
There was a problem hiding this comment.
also set this schema.src to file://schema.hcl or file://schema.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the hashing mechanism by using
schema inspect. This change ensures that the Operator correctly detects changes in the remote schema.