Drop js dependencies and build tools #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a few lines of JavaScript to handle base64url encoding and decoding of the array buffers that the browser returns/expects, so we can convert to the json format that the server expects. Previously this used a third-party library, but that requires bringing in Yarn and Packer to manage this, which results in a transitive dependency on almost 600k lines of JavaScript (excluding blank lines and comments) and another 9k lines of TypeScript. By implementing the conversion by hand, we reduce the footprint of the example by: * Dropping the 64 MB node_modules directory. * Reducing the size of the dev dependencies Nix closure by 100 MB. * Removing the 6.4 seconds required to run Yarn initially. * Removing the 4.3 seconds required to run Parcel initially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few lines of JavaScript to handle base64url encoding and decoding of the array buffers that the browser returns/expects, so we can convert to the json format that the server expects.
Previously this used a third-party library, but that requires bringing in Yarn and Packer to manage this, which results in a transitive dependency on almost 600k lines of JavaScript (excluding blank lines and comments) and another 9k lines of TypeScript.
By implementing the conversion by hand, we reduce the footprint of the example by:
node_modulesdirectory.@arianvp mentioned it would be good to keep the third-party base64 encoder/decoder as an option, for people who care more about the ease of use of the example, than about the total footprint. I’ll look into restoring the Yarn/Packer workflow as an option.