Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New sync flags for replace and force #653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrii-korotkov-verkada
Copy link
Contributor

Gitops-engine part of argoproj/argo-cd#20730

Add new way of specifying options and include options like always, never, if-requested, if-immutable-fields-updated, if-apply-failed. Tests can be better, but I haven't figure out how to configure apply failur with existing mocks.

Gitops-engine part of argoproj/argo-cd#20730

Add new way of specifying options and include options like always, never, if-requested, if-immutable-fields-updated, if-apply-failed.
Tests can be better, but I haven't figure out how to configure apply failur with existing mocks.

Signed-off-by: Andrii Korotkov <[email protected]>
@andrii-korotkov-verkada andrii-korotkov-verkada requested a review from a team as a code owner December 13, 2024 16:51
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 66.19718% with 24 lines in your changes missing coverage. Please review.

Project coverage is 54.25%. Comparing base (8849c3f) to head (855b7b5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sync/sync_context.go 66.19% 22 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   54.26%   54.25%   -0.01%     
==========================================
  Files          64       64              
  Lines        6164     6211      +47     
==========================================
+ Hits         3345     3370      +25     
- Misses       2549     2570      +21     
- Partials      270      271       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant