Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object-level prune propagation policy, propagation policy for kubectl replace #561

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sthomson-wyn
Copy link

  • add object-level prune propagation configuration
  • add cascading option for kubectl replace

Fixes argoproj/argo-cd#8501

…iguration

- add cascading option for kubectl replace

Signed-off-by: Stewart Thomson <[email protected]>
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: Patch coverage is 54.90196% with 23 lines in your changes missing coverage. Please review.

Project coverage is 54.58%. Comparing base (5fd9f44) to head (6379eb8).
Report is 8 commits behind head on master.

Current head 6379eb8 differs from pull request most recent head 26ebfe9

Please upload reports for the commit 26ebfe9 to get more accurate results.

Files Patch % Lines
pkg/sync/sync_context.go 65.11% 14 Missing and 1 partial ⚠️
pkg/utils/kube/resource_ops.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   54.71%   54.58%   -0.14%     
==========================================
  Files          41       41              
  Lines        4834     4857      +23     
==========================================
+ Hits         2645     2651       +6     
- Misses       1977     1993      +16     
- Partials      212      213       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ation-policy

# Conflicts:
#	pkg/sync/sync_context.go
#	pkg/utils/kube/kubetest/mock_resource_operations.go
#	pkg/utils/kube/resource_ops.go
…ation-policy

# Conflicts:
#	pkg/sync/sync_context.go
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code

See analysis details on SonarCloud

…lace-propagation-policy

# Conflicts:
#	pkg/sync/sync_context.go
#	pkg/utils/kube/kubetest/mock_resource_operations.go
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.4% Duplication on New Code

See analysis details on SonarCloud

…lace-propagation-policy

# Conflicts:
#	pkg/utils/kube/resource_ops.go
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.8% Duplication on New Code

See analysis details on SonarCloud

@agershman
Copy link

When do we expect this change to land?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PVCs WITHOUT disrupting service - using sync option
2 participants