Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): set pagination limit to 100 by default #3565

Closed
wants to merge 1 commit into from

Conversation

clementlecorre
Copy link

@clementlecorre clementlecorre commented Jul 23, 2020

Checklist:

  • [c] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Hello!

Here is a proposal to change the maximum number of workflow on a page.

The pagination is a really cool feature, but I have 1000 workflow to load and it's long (with all).

Thanks !

@alexec
Copy link
Contributor

alexec commented Jul 23, 2020

One of the challenges with this view is that results are returned from the server in a random order, not in time order. Pagination loose this.

@alexec alexec changed the title chore(ui/pagination): 100 is max pagination for default feat(ui): 100 is max pagination for default Jul 23, 2020
@simster7
Copy link
Member

As @alexec mentioned, this is unfortunately a limitation from K8s. When we ask K8s to do pagination, it returns all the Workflows in a random order. Because of this, when using pagination we won't be able to show latest Workflows first on the list. Since we believe most users want this ordering, we have set all to be the default.

See kubernetes/kubernetes#80602 (comment) for the K8s issue

@simster7 simster7 closed this Jul 23, 2020
@agilgur5 agilgur5 changed the title feat(ui): 100 is max pagination for default feat(ui): set 100 as default for max pagination Mar 5, 2024
@agilgur5 agilgur5 changed the title feat(ui): set 100 as default for max pagination feat(ui): set pagination limit to 100 by default Mar 5, 2024
@agilgur5
Copy link
Member

When we ask K8s to do pagination, it returns all the Workflows in a random order.

Noting here that server-side sorting should be possible after #12736 (running an in-memory SQLite DB)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants