Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Add namespace input to ClusterWorkflowTemplate submit. Fixes #10398 #13596

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(ui): Add namespace input to ClusterWorkflowTemplate submit. Fixes #10398 #13596

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c090cfb
feat(ui): Set namespace when submitting ClusterWorkflowTemplate
MasonM Sep 13, 2024
59dbea3
fix(ui): lift up React state and move namespace input
MasonM Sep 14, 2024
fccd308
fix(ui): reorder import
MasonM Sep 15, 2024
2a234f1
Merge branch 'main' into feat-10398
MasonM Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/app/cluster-workflow-templates/cluster-workflow-template-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export function ClusterWorkflowTemplateDetails({history, location, match}: Route
<SubmitWorkflowPanel
kind='ClusterWorkflowTemplate'
namespace={namespace}
onNamespaceChange={setNamespace}
name={template.metadata.name}
entrypoint={template.spec.entrypoint}
templates={template.spec.templates || []}
Expand Down
10 changes: 9 additions & 1 deletion ui/src/app/workflows/components/submit-workflow-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {Select} from 'argo-ui/src/components/select/select';
import {TextInput} from '../../shared/components/text-input';
agilgur5 marked this conversation as resolved.
Show resolved Hide resolved
import React, {useContext, useMemo, useState} from 'react';

import {Parameter, Template} from '../../../models';
Expand All @@ -11,8 +12,9 @@ import {services} from '../../shared/services';
import {Utils} from '../../shared/utils';

interface Props {
kind: string;
kind: 'ClusterWorkflowTemplate' | 'WorkflowTemplate';
namespace: string;
onNamespaceChange?: (namespace: string) => void;
name: string;
entrypoint: string;
templates: Template[];
Expand Down Expand Up @@ -73,6 +75,12 @@ export function SubmitWorkflowPanel(props: Props) {
</h5>
{error && <ErrorNotice error={error} />}
<div className='white-box'>
{props.onNamespaceChange && (
<div key='namespace' style={{marginBottom: 25}}>
<label>Namespace</label>
<TextInput value={props.namespace} onChange={props.onNamespaceChange} />
</div>
)}
<div key='entrypoint' title='Entrypoint' style={{marginBottom: 25}}>
<label>Entrypoint</label>
<Select
Expand Down
Loading