Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert #11761 to avoid argo-server performance issue #12068

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

terrytangyuan
Copy link
Member

This reverts #11761. See #12025 for context.

@juliev0
Copy link
Contributor

juliev0 commented Oct 23, 2023

Just want to make sure - can you confirm that there are no changes that were made after this change that were dependent on it?

@terrytangyuan
Copy link
Member Author

Just want to make sure - can you confirm that there are no changes that were made after this change that were dependent on it?

Yes that is the last change to https://github.com/argoproj/argo-workflows/blob/master/server/workflow/workflow_server.go

@terrytangyuan terrytangyuan enabled auto-merge (squash) October 23, 2023 17:45
@agilgur5 agilgur5 added area/api Argo Server API area/server labels Oct 23, 2023
Signed-off-by: Yuan Tang <[email protected]>
@terrytangyuan terrytangyuan merged commit 08096fc into argoproj:master Oct 24, 2023
26 of 27 checks passed
@terrytangyuan terrytangyuan deleted the revert-pagination-fix branch October 24, 2023 01:32
terrytangyuan added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants