Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set argo-rollouts-notification-secret in metadata.name in the description of Store Oauth access token #3943

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chansuke
Copy link
Contributor

Closes #3942

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (5f59344) to head (d1f9d74).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3943      +/-   ##
==========================================
- Coverage   82.69%   82.66%   -0.04%     
==========================================
  Files         163      163              
  Lines       22895    22895              
==========================================
- Hits        18934    18927       -7     
- Misses       3087     3092       +5     
- Partials      874      876       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Published E2E Test Results

  4 files    4 suites   3h 19m 6s ⏱️
113 tests 100 ✅  7 💤  6 ❌
464 runs  425 ✅ 28 💤 11 ❌

For more details on these failures, see this check.

Results for commit d1f9d74.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Published Unit Test Results

2 280 tests   2 280 ✅  3m 0s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit d1f9d74.

♻️ This comment has been updated with latest results.

@chansuke chansuke marked this pull request as draft November 14, 2024 03:52
@chansuke chansuke marked this pull request as ready for review November 15, 2024 06:30
@kostis-codefresh kostis-codefresh added the docs Needs documentation/release notes label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Needs documentation/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct the yaml of Store Oauth access token in argo-rollouts-notification-secret secret doc
2 participants