fix(argo-cd): Fix repo-server honorLabels config template #3075
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symaras
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
Signed-off-by: symaras <[email protected]>
Signed-off-by: symaras <[email protected]>
Signed-off-by: symaras <[email protected]>
mbevc1
reviewed
Dec 11, 2024
Signed-off-by: symaras <[email protected]>
mbevc1
approved these changes
Dec 11, 2024
yu-croco
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in 0061e14#diff-ef4a32480a793da4e68fa5b4e320523c5a1acf86064769abfc1d97a1462143eeR38 where the honorLabels config for the repo-server was put inside the
withstatement. In that case, if.Values.repoServer.metrics.serviceMonitor.schemeis set, the honorLabels value can't be found because the.Valuesobject is not accessible from within thewithblock.Checklist: