Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-rollouts): controller replicas count comparison #2309

Merged
merged 2 commits into from
Oct 24, 2023
Merged

fix(argo-rollouts): controller replicas count comparison #2309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f29ffa5
fix(argo-rollouts): use integet instead of float for controller replicas
jmeridth Oct 24, 2023
c249a31
Merge branch 'main' into jm-argo-rollouts-deployment-fix
tico24 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/argo-rollouts/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v1.6.0
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.32.0
version: 2.32.1
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
Expand All @@ -18,5 +18,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Upgrade Argo Rollouts to v1.6.0
- kind: fixed
description: Use integer instead of float for controller replicas
2 changes: 1 addition & 1 deletion charts/argo-rollouts/templates/controller/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ spec:
{{- if not .Values.clusterInstall }}
- --namespaced
{{- end }}
{{- if gt .Values.controller.replicas 1.0 }}
{{- if gt (int .Values.controller.replicas) 1 }}
- --leader-elect
{{- end }}
{{- with .Values.controller.extraArgs }}
Expand Down