-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: golang 1.21 #3002
base: master
Are you sure you want to change the base?
Chore: golang 1.21 #3002
Conversation
6ef7c2e
to
1815e35
Compare
Thanks @shyukri ! could you figure out why the lint is failing? |
971fdf4
to
c6150ad
Compare
Issues even after upgrading the linter:
```
# make lint
INFO [runner] linters took 26.82040325s with stages: goanalysis_metalinter: 26.7034705s
|
I think you should remove |
1f405f0
to
f3ec013
Compare
@ryancurrah @whynowy can you please re-check ? |
f3ec013
to
3f49938
Compare
Makefile
Outdated
@@ -38,6 +39,7 @@ override LDFLAGS += -X ${PACKAGE}.gitTag=${GIT_TAG} | |||
endif | |||
|
|||
K3D ?= $(shell [ "`command -v kubectl`" != '' ] && [ "`command -v k3d`" != '' ] && [[ "`kubectl config current-context`" =~ k3d-* ]] && echo true || echo false) | |||
K3DCLUSTER?=e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires everyone to create a cluster e2e
. Can we still use default K3DCLUSTER?=k3s-default
?
All the reset looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
- name: Create k3d registry and cluster | ||
run: | | ||
k3d registry create e2e-registry --port 5111 | ||
k3d cluster create e2e -i rancher/k3s:v1.21.7-k3s1 --registry-use k3d-e2e-registry:5111 | ||
k3d cluster create -i rancher/k3s:v1.27.10-k3s2 --registry-use k3d-e2e-registry:5111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not need to remove e2e
here for the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@ryancurrah do you need any assistance? I was considering opening a separate lint fix pr |
6787d3d
to
82ee2e4
Compare
- name: Create k3d registry and cluster | ||
run: | | ||
k3d registry create e2e-registry --port 5111 | ||
k3d cluster create e2e -i rancher/k3s:v1.21.7-k3s1 --registry-use k3d-e2e-registry:5111 | ||
k3d cluster create -i rancher/k3s:v1.27.10-k3s2 --registry-use k3d-e2e-registry:5111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k3d cluster create -i rancher/k3s:v1.27.10-k3s2 --registry-use k3d-e2e-registry:5111 | |
k3d cluster create e2e-i rancher/k3s:v1.27.10-k3s2 --registry-use k3d-e2e-registry:5111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -1,5 +1,5 @@ | |||
# Golang binary building stage | |||
FROM golang:1.20.2 | |||
FROM golang:1.21.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FROM golang:1.21.6 | |
FROM golang:1.21 |
Its hard to keep up with patch releases, I suggest we use major minor tags which will always use the latest patch release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to track down possible issues if the image is not static.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
9f8386f
to
df8e15f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Shyukri Shyukriev <[email protected]>
Signed-off-by: Shyukri Shyukriev <[email protected]>
Signed-off-by: Shyukri Shyukriev <[email protected]>
Signed-off-by: Shyukri Shyukriev <[email protected]>
Signed-off-by: Shyukri Shyukriev <[email protected]>
Signed-off-by: Shyukri Shyukriev <[email protected]>
Signed-off-by: Shyukri Shyukriev <[email protected]> chore: upgrade k3d to k8s 1.27, specify kubeconfig as k3d defaults to k3s-default name Signed-off-by: Shyukri Shyukriev <[email protected]> chore: use k3s-default as cluster and drop it from GHA Signed-off-by: Shyukri Shyukriev <[email protected]>
Signed-off-by: Shyukri Shyukriev <[email protected]>
df8e15f
to
03e18d9
Compare
Hello! Is there any updates on this PR? We are blocked on our end pending the resolution of a few CVEs that are present in the older Go version used in the latest release. |
@whynowy any chance to take another look ? Or should we jump to golang 1.22 :) ? |
@whynowy re |
This Pull Request is stale because it has been open for 60 days with |
Checklist:
This has also gone bigger than anticipated: