feat: add alibabacloud mns as eventsource #2951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangkun
force-pushed
the
feat/AddMNS
branch
2 times, most recently
from
412078f to
6df3dac
Compare
5 tasks
whynowy
reviewed
Jan 1, 2024
| log.Infof("visibility changed: %v\n", ret) | ||
| log.Infof("delete it now: %v\n", ret.ReceiptHandle) | ||
| if e := queue.DeleteMessage(ret.ReceiptHandle); e != nil { | ||
| fmt.Println(e) |
| } | ||
| queue := ali_mns.NewMNSQueue(el.MNSEventSource.Queue, *mnsClient, 50) | ||
|
|
||
| for { |
There was a problem hiding this comment.
Curious, how to break this for loop when the application exits?
shuangkun
force-pushed
the
feat/AddMNS
branch
2 times, most recently
from
23919dd to
ab2dc43
Compare
whynowy
reviewed
Jan 8, 2024
| case resp := <-respChan: | ||
| { | ||
| log.Infof("response: %v \n", resp) | ||
| log.Infof("change the visibility: %v \n", resp.ReceiptHandle) |
| } | ||
| eventBytes, err := json.Marshal(eventData) | ||
| if err != nil { | ||
| log.Errorf("failed to marshal the event data, rejecting the event, %w", err) |
There was a problem hiding this comment.
Instead of dispatching, should it be skipped when there's an error?
| if err = dispatch(eventBytes); err != nil { | ||
| log.Errorf("failed to dispatch ali mns event, %w", err) | ||
| } | ||
| if ret, e := queue.ChangeMessageVisibility(resp.ReceiptHandle, 5); e != nil { |
There was a problem hiding this comment.
What is the reason it needs to change visibility before deleting?
| log.Errorf("failed to dispatch ali mns event, %w", err) | ||
| } | ||
| if ret, e := queue.ChangeMessageVisibility(resp.ReceiptHandle, 5); e != nil { | ||
| log.Info(e) |
| log.Infof("visibility changed: %v\n", ret) | ||
| log.Infof("delete it now: %v\n", ret.ReceiptHandle) | ||
| if e := queue.DeleteMessage(ret.ReceiptHandle); e != nil { | ||
| log.Infof("delete err: %v\n", e.Error()) |
| errChan := make(chan error) | ||
| endChan := make(chan int) | ||
| go func() { | ||
| select { |
There was a problem hiding this comment.
How to exit this goroutine when receiving a SIGTERM?
shuangkun
force-pushed
the
feat/AddMNS
branch
2 times, most recently
from
ed51272 to
367e745
Compare
Signed-off-by: shuangkun <[email protected]>
shuangkun
force-pushed
the
feat/AddMNS
branch
from
367e745 to
bf99dcf
Compare
|
This Pull Request is stale because it has been open for 60 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Add AlibabaCloud MNS as eventsource for argo-events.