replaced govaluate with expr #2911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
force-pushed
the
replace-govaluate-with-expr
branch
from
d71adce to
5b93aad
Compare
AndrewChubatiuk
force-pushed
the
replace-govaluate-with-expr
branch
6 times, most recently
from
20c32ed to
8215f19
Compare
whynowy
reviewed
Dec 19, 2023
| @@ -65,7 +66,7 @@ func NewJetstreamTriggerConn(conn *jetstreambase.JetstreamConnection, | |||
| recentMsgsByTime: make([]*msg, 0)} | |||
| connection.Logger = connection.Logger.With("triggerName", connection.triggerName, "sensorName", connection.sensorName) | |||
|
|
|||
| connection.evaluableExpression, err = govaluate.NewEvaluableExpression(strings.ReplaceAll(dependencyExpression, "-", "\\-")) | |||
| connection.evaluableExpression, err = expr.Compile(dependencyExpression) | |||
There was a problem hiding this comment.
Don't need to escape it any more?
There was a problem hiding this comment.
wanted to deprecate - in naming, cause it limits subtract operations, reverted this change for now. want to add abilities to set priorities later in trigger conditions
| @@ -7,17 +7,17 @@ spec: | |||
| serviceAccountName: operate-workflow-sa | |||
| # defines list of all events sensor will accept | |||
| dependencies: | |||
| - name: test-dep | |||
| - name: TestDep | |||
There was a problem hiding this comment.
Curious, what's the reason to change?
There was a problem hiding this comment.
reverted it as well, not relevant anymore
AndrewChubatiuk
force-pushed
the
replace-govaluate-with-expr
branch
5 times, most recently
from
527b927 to
40735cd
Compare
AndrewChubatiuk
force-pushed
the
replace-govaluate-with-expr
branch
from
40735cd to
453f71c
Compare
AndrewChubatiuk
force-pushed
the
replace-govaluate-with-expr
branch
from
453f71c to
ccb5871
Compare
|
@whynowy could you please review it again? |
AndrewChubatiuk
force-pushed
the
replace-govaluate-with-expr
branch
2 times, most recently
from
fddf83f to
47eccb2
Compare
Signed-off-by: AndrewChubatiuk <[email protected]>
AndrewChubatiuk
force-pushed
the
replace-govaluate-with-expr
branch
from
47eccb2 to
08db235
Compare
|
This Pull Request is stale because it has been open for 60 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed govaluate, which is not maintained and left expr only instead