Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventbus): add exotic jetstream support #2878

Merged
merged 13 commits into from
Oct 25, 2023

Conversation

gokulav137
Copy link
Contributor

@gokulav137 gokulav137 commented Oct 21, 2023

Add support for exotic jetstream eventbus

Resolves #2462

apiVersion: argoproj.io/v1alpha1
kind: EventBus
metadata:
  name: default
spec:
  jetstreamExotic:
      url: nats://xxxxx:xxx
      accessSecret:
        name: my-secret-name
        key: secret-key
      streamConfig: ""

Tested end to end

  • created a nats jetstream using helm charts in a different namespace
  • created a webhook eventsource
  • created a sensor with email trigger
  • sent a post request and validated that email was received

Checklist:

gokulav137 and others added 11 commits September 9, 2023 18:38
feat: add all sprig functions to templates (argoproj#2768)
	- Add exotic jetstream installer
	- Add exotic jetstream installer ot installer.go
	- Add exotic jetream spec validation to eventbus controller
	- Add exotic jetstream to eventbus types
	- Add update validation for exotic jetstream

Signed-off-by: gokulav137 <[email protected]>
Signed-off-by: gokulav137 <[email protected]>
… initialization for jetstreamExotic

Signed-off-by: gokulav137 <[email protected]>
	- add test to update native nats to exotic js
	- add test when url is missing for exotic js
	- add test when exotic js has correct properties
	- add test for exotic js install/uninstall

Signed-off-by: gokulav137 <[email protected]>
@gokulav137 gokulav137 force-pushed the exotic-jetstream branch 3 times, most recently from a4107a8 to 266fedf Compare October 22, 2023 06:46
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whynowy whynowy merged commit 79ea8a6 into argoproj:master Oct 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "exotic" equivalent for Jetstream EventBuses
2 participants