feat: use log format config for klog (#5715) #21458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21458 +/- ##
==========================================
+ Coverage 55.22% 55.25% +0.03%
==========================================
Files 337 337
Lines 56919 56922 +3
==========================================
+ Hits 31431 31450 +19
+ Misses 22808 22799 -9
+ Partials 2680 2673 -7 ☔ View full report in Codecov by Sentry. |
leoluz
approved these changes
Jan 13, 2025
| ) | ||
|
|
||
| const ( | ||
| binaryNameEnv = "ARGOCD_BINARY_NAME" | ||
| ) | ||
|
|
||
| func init() { | ||
| // Make sure klog uses the configured log level and format. | ||
| klog.SetLogger(log.NewLogrusLogger(log.NewWithCurrentConfig())) |
There was a problem hiding this comment.
The problem with static loggers is that anybody can change this configs in a different package which would reflect in the entire application. Unfortunately, at this point there is no much we can do to improve this situation other than refactoring the log usage in the entire codebase.
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
* feat: use log format config for klog (argoproj#5715) Signed-off-by: Michael Crenshaw <[email protected]> * use init, remove test line Signed-off-by: Michael Crenshaw <[email protected]> * sort imports Signed-off-by: Michael Crenshaw <[email protected]> * fix comment Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Brett C. Dudo <[email protected]>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
* feat: use log format config for klog (argoproj#5715) Signed-off-by: Michael Crenshaw <[email protected]> * use init, remove test line Signed-off-by: Michael Crenshaw <[email protected]> * sort imports Signed-off-by: Michael Crenshaw <[email protected]> * fix comment Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
flbla
pushed a commit
to flbla/argo-cd
that referenced
this pull request
Jan 20, 2025
* feat: use log format config for klog (argoproj#5715) Signed-off-by: Michael Crenshaw <[email protected]> * use init, remove test line Signed-off-by: Michael Crenshaw <[email protected]> * sort imports Signed-off-by: Michael Crenshaw <[email protected]> * fix comment Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: flbla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5715
Modeled on https://github.com/argoproj/argo-rollouts/pull/2701/files
Took the opportunity to upgrade the adapter package.
Test: