Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use testify instead of testing.Fatal or testing.Error in reposerver #20762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: use testify instead of testing.Fatal or testing.Error in reposerver #20762

wants to merge 1 commit into from
+31 −62

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 12, 2024 •
edited
Loading

Description

  • uses testify instead of testing.Fatal or testing.Error in reposerver

@mmorel-35 mmorel-35 requested a review from a team as a code owner November 12, 2024 06:47
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Nov 12, 2024 •
edited
Loading

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@mmorel-35 mmorel-35 force-pushed the testifier/reposerver branch 8 times, most recently from 47e5cba to 577a388 Compare November 12, 2024 07:39
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.16%. Comparing base (6d8d32f) to head (d9d248d).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #20762      +/-   ##
============================================
  Coverage          ?   55.16%              
============================================
  Files             0      324     +324     
  Lines             0    55256   +55256     
============================================
+ Hits              0    30484   +30484     
- Misses            0    22152   +22152     
- Partials          0     2620    +2620

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrii-korotkov-verkada
andrii-korotkov-verkada reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-run or fix the CI.

reposerver/cache/cache_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-korotkov-verkada andrii-korotkov-verkada andrii-korotkov-verkada left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @andrii-korotkov-verkada