Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: periodically detect and update cluster connection status #18143

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chetan-rns
Copy link
Member

Argo CD doesn't report connection errors on the cluster UI page unless the cache is invalidated (manually/periodically every 24 hours) or there is a sync error. This error is only updated during auto-sync if there is a new commit to sync. This PR adds a new field ConnectionStatus that gets updated whenever Argo CD fails to access the cluster. The ClusterInfoUpdater will periodically fetch this cluster info and update the cache.

The cluster cache will start a goroutine with a configurable interval that pings (calls the version API) the remote cluster and checks if the cluster is reachable. It only pings the remote cluster if it detects any watch errors in the cluster cache thereby avoiding unnecessary calls. The implementation can be found here: argoproj/gitops-engine#559

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@chetan-rns chetan-rns requested a review from a team as a code owner May 9, 2024 12:57
@chetan-rns chetan-rns force-pushed the update-cluster-connection branch from 7f52294 to bd90f67 Compare May 9, 2024 13:18
@chetan-rns chetan-rns force-pushed the update-cluster-connection branch from bd90f67 to 6c1ba04 Compare May 30, 2024 11:18
@chetan-rns chetan-rns force-pushed the update-cluster-connection branch from 6c1ba04 to ab31168 Compare May 30, 2024 12:18
Signed-off-by: Chetan Banavikalmutt <[email protected]>
@chetan-rns chetan-rns force-pushed the update-cluster-connection branch from ab31168 to cd0f052 Compare May 30, 2024 12:34
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 20.68966% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 44.91%. Comparing base (21b1514) to head (cd0f052).
Report is 9 commits behind head on master.

Files Patch % Lines
controller/cache/cache.go 8.00% 22 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18143      +/-   ##
==========================================
- Coverage   44.93%   44.91%   -0.03%     
==========================================
  Files         354      354              
  Lines       47742    47722      -20     
==========================================
- Hits        21454    21435      -19     
- Misses      23485    23488       +3     
+ Partials     2803     2799       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ikauzak
Copy link

ikauzak commented Jul 22, 2024

hey there. We are looking for this feature as well. Any estimation date of when this will be merged? thank you

@andrii-korotkov-verkada
Copy link
Contributor

What if the connections errors are intermittent? Reporting on the UI can be noisy.
Can you open an issue and give a more detailed context on how it would solve the problems, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants