chore: use testify instead of testing.Fatal or testing.Error in cmd

Signed-off-by: Matthieu MOREL <[email protected]>
argoproj · Nov 11, 2024 · fa62a82 · fa62a82
1 parent 0dacc2e
commit fa62a82
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/cmd/argocd/commands/utils/prompt_test.go b/cmd/argocd/commands/utils/prompt_test.go
@@ -5,6 +5,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestNewPrompt_PromptsEnabled_True(t *testing.T) {
@@ -57,9 +58,7 @@ func TestConfirmPrompt(t *testing.T) {
 
 	for _, c := range cases {
 		tmpFile, err := writeToStdin(c.input)
-		if err != nil {
-			t.Fatal(err)
-		}
+		require.NoError(t, err)
 		p := &Prompt{enabled: true}
 		result := p.Confirm("Are you sure you want to run this command? (y/n) \n")
 		assert.Equal(t, c.output, result)
@@ -85,9 +84,7 @@ func TestConfirmAllPrompt(t *testing.T) {
 
 	for _, c := range cases {
 		tmpFile, err := writeToStdin(c.input)
-		if err != nil {
-			t.Fatal(err)
-		}
+		require.NoError(t, err)
 		p := &Prompt{enabled: true}
 		confirm, confirmAll := p.ConfirmAll("Are you sure you want to run this command? (y/n) \n")
 		assert.Equal(t, c.confirm, confirm)

diff --git a/cmd/argocd/commands/version_test.go b/cmd/argocd/commands/version_test.go
@@ -17,8 +17,7 @@ func TestShortVersionClient(t *testing.T) {
 	cmd.SetOut(buf)
 	cmd.SetArgs([]string{"version", "--short", "--client"})
 	require.NoError(t, cmd.Execute(), "Failed to execute short version command")
-	output := buf.String()
-	assert.Equal(t, "argocd: v99.99.99+unknown\n", output)
+	assert.Equal(t, "argocd: v99.99.99+unknown\n", buf.String())
 }
 
 func TestShortVersion(t *testing.T) {