Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple backend refs #53

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

tommy351
Copy link
Contributor

Currently, this plugin only modifies the weight of the first matching backend refs. I changed the setHTTPRouteWeight and setTCPRouteWeight functions to modify the weights of all matching backend refs.

@tommy351 tommy351 force-pushed the multiple-backend-refs branch 3 times, most recently from 2670ff3 to 2f95385 Compare April 26, 2024 09:20
@Philipp-Plotnikov
Copy link
Collaborator

Hi @tommy351 ! Thank you for contribution, please

  1. Resolve conflicts
  2. Remove empty lines
    When you will finish, please ping me

@Philipp-Plotnikov Philipp-Plotnikov added the enhancement New feature or request label Apr 27, 2024
@Philipp-Plotnikov Philipp-Plotnikov changed the title Support multiple backend refs feat: support multiple backend refs Apr 27, 2024
@tommy351 tommy351 force-pushed the multiple-backend-refs branch 2 times, most recently from 3b48d48 to efff2fc Compare April 29, 2024 03:18
@tommy351
Copy link
Contributor Author

@Philipp-Plotnikov Fixed in 9eded55

Copy link
Collaborator

@Philipp-Plotnikov Philipp-Plotnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @tommy351 !

@Philipp-Plotnikov Philipp-Plotnikov merged commit 47954c2 into argoproj-labs:main Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants