Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FROM path in Dockerfile recommendation #662

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jbouter
Copy link

@jbouter jbouter commented Sep 11, 2024

Pulling from argoproj/argocd:latest uses the preferred registry from the user. If this is dockerhub, it will pull a very outdated image of argocd.

Description

The docs recommend using a FROM that can possibly be broken

Fixes: <! -- link to issue -->

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

Pulling from `argoproj/argocd:latest` uses the preferred registry from the user. If this is dockerhub, it will pull a very outdated image of argocd.

Signed-off-by: Jeffrey Bouter <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (42a43f0) to head (8806a0f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
+ Coverage   72.16%   73.55%   +1.38%     
==========================================
  Files          26       26              
  Lines        1994     1588     -406     
==========================================
- Hits         1439     1168     -271     
+ Misses        458      315     -143     
- Partials       97      105       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@werne2j werne2j self-requested a review September 29, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants