Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ibmsm]: Add support for service_credentials secret type #629

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jgawor
Copy link
Contributor

@jgawor jgawor commented Apr 19, 2024

Description

Add support for service_credentials secret type.

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.21 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

Signed-off-by: Jarek Gawor <[email protected]>
Signed-off-by: Jarek Gawor <[email protected]>
Signed-off-by: Jarek Gawor <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (42a43f0) to head (8bf621a).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   72.16%   73.91%   +1.74%     
==========================================
  Files          26       26              
  Lines        1994     1606     -388     
==========================================
- Hits         1439     1187     -252     
+ Misses        458      314     -144     
- Partials       97      105       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's adding support for another secret type and it looks like it works like the others do, so no need to add to docs.

Thanks!

@jgawor
Copy link
Contributor Author

jgawor commented May 27, 2024

@werne2j could you please take a look at this PR? thanks.

Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just rebase the branch and then we can merge.

Signed-off-by: Jarek Gawor <[email protected]>
@jgawor jgawor force-pushed the ibm_secret_manager_service_creds branch from fa2dad5 to 86fdaa9 Compare June 14, 2024 22:25
@jgawor
Copy link
Contributor Author

jgawor commented Jun 15, 2024

@werne2j updated now

@jgawor
Copy link
Contributor Author

jgawor commented Jun 27, 2024

@werne2j one more ping :)

@jgawor
Copy link
Contributor Author

jgawor commented Jul 19, 2024

@werne2j one more ping

@jgawor
Copy link
Contributor Author

jgawor commented Aug 4, 2024

@werne2j and one more ping.

@jgawor
Copy link
Contributor Author

jgawor commented Aug 6, 2024

@jkayani maybe you can merge?

@werne2j
Copy link
Member

werne2j commented Sep 29, 2024

@jgawor looks like there are conflicts. Once resolved i will merge this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants