Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new Kubernetes Secret backend #521

Merged

Conversation

dennislapchenko
Copy link
Contributor

@dennislapchenko dennislapchenko commented Jun 20, 2023

Description

Add a new backend: Kubernetes Secret.

Fixes: #516

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@dennislapchenko dennislapchenko force-pushed the feature/kubernetes-secret-backend branch 3 times, most recently from 4af0cf8 to 98b7116 Compare June 20, 2023 13:44
Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @dennislapchenko! My biggest question is around the idea of the "default" secret and whether it is necessary.

docs/backends.md Outdated Show resolved Hide resolved
docs/backends.md Outdated Show resolved Hide resolved
Signed-off-by: Dennis Lapchenko <[email protected]>
@dennislapchenko dennislapchenko force-pushed the feature/kubernetes-secret-backend branch from 16a8c86 to aeeedf1 Compare June 21, 2023 07:55
@dennislapchenko
Copy link
Contributor Author

dennislapchenko commented Jun 21, 2023

Thanks for the contribution @dennislapchenko! My biggest question is around the idea of the "default" secret and whether it is necessary.

Cheers @werne2j , I have removed the "default" secret and updated the documentation with [tested] namespace examples.

@dennislapchenko
Copy link
Contributor Author

hey @werne2j , any info on when this can be released? Or any other comments please?

@dennislapchenko
Copy link
Contributor Author

Hi @werne2j or @jkayani , apologies for being so persistent.
How would you like to proceed with this? Is everything to your liking?

Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #521 (6c165be) into main (1934033) will decrease coverage by 0.42%.
The diff coverage is 47.50%.

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   71.06%   70.65%   -0.42%     
==========================================
  Files          25       26       +1     
  Lines        1911     1949      +38     
==========================================
+ Hits         1358     1377      +19     
- Misses        455      472      +17     
- Partials       98      100       +2     
Impacted Files Coverage Δ
pkg/kube/client.go 0.00% <0.00%> (ø)
pkg/backends/kubernetessecret.go 53.57% <53.57%> (ø)
pkg/config/config.go 84.40% <100.00%> (+0.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@werne2j werne2j merged commit 3c53937 into argoproj-labs:main Jul 15, 2023
3 checks passed
@acelinkio
Copy link
Contributor

Any chance we could cut a new release to close #516 . Super excited to use this!

@dennislapchenko
Copy link
Contributor Author

Any chance we could cut a new release to close #516 . Super excited to use this!

Agree!

Maybe you can accelerate it if you submit a 1.16 release PR with version bumps (they did similar with 1.15)

@acelinkio acelinkio mentioned this pull request Jul 29, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants