Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling empty list statistics #1094

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

gabrielmbmb
Copy link
Member

@gabrielmbmb gabrielmbmb commented Jan 10, 2025

Description

This PRs fixes some errors that could occur if an LLM returned input_tokens and output_tokens statistics as an empty list. In addition, it updates the prepare_output function so if no input_tokens or output_tokens are provided, then no keys are added to statistics avoiding the original error.

Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-1094/

Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #1094 will not alter performance

Comparing fix-aggregating-statistics (5a36802) with develop (2c893c1)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb requested a review from plaguss January 10, 2025 13:28
@gabrielmbmb gabrielmbmb self-assigned this Jan 10, 2025
@gabrielmbmb gabrielmbmb added this to the 1.5.0 milestone Jan 10, 2025
@gabrielmbmb gabrielmbmb marked this pull request as ready for review January 10, 2025 13:36
@davidberenstein1957 davidberenstein1957 merged commit d9fd15c into develop Jan 10, 2025
8 checks passed
@davidberenstein1957 davidberenstein1957 deleted the fix-aggregating-statistics branch January 10, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants