Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move API handlers folder structure #4955

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Jun 5, 2024

Description

This PR include changes moving API handlers to follow this structure:

/api
  /handlers
    /v1
      records.py
      questions.py
      ...

The behavior has not been changed.

Refs #4868

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test should be passing as before.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon June 5, 2024 11:46
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only comment here is to remove changes to the argilla project. By fixing it to server version ~=1.29.0, all this change won't affect it.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.38%. Comparing base (bb1b41b) to head (a41aae5).

Current head a41aae5 differs from pull request most recent head df7f0ce

Please upload reports for the commit df7f0ce to get more accurate results.

Additional details and impacted files
@@                              Coverage Diff                               @@
##           refactor/api-folder-structure-improvements    #4955      +/-   ##
==============================================================================
- Coverage                                       91.39%   91.38%   -0.01%     
==============================================================================
  Files                                             136      136              
  Lines                                            5831     5829       -2     
==============================================================================
- Hits                                             5329     5327       -2     
  Misses                                            502      502              
Flag Coverage Δ
argilla-server 91.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo requested a review from frascuchon June 6, 2024 15:13
Base automatically changed from refactor/api-schemas-structure-improvements to refactor/api-folder-structure-improvements June 7, 2024 10:48
@jfcalvo jfcalvo merged commit 82b6811 into refactor/api-folder-structure-improvements Jun 7, 2024
2 of 3 checks passed
@jfcalvo jfcalvo deleted the refactor/api-handlers-structure-improvements branch June 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants