Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: apply some of suggested changes #4644

Merged
merged 3 commits into from
Mar 13, 2024
Merged

chore: apply some of suggested changes #4644

merged 3 commits into from
Mar 13, 2024

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Mar 11, 2024 •
edited
Loading

This PR adds the text value for span suggestions and responses when publishing HF datasets. Commented by @davidberenstein1957 here

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 11, 2024
@dosubot dosubot bot added area: tests Indicates that an issue or pull request is related to the tests language: python Pull requests or issues that update Python code severity: minor Indicates that the issue isn't urgent or blocking team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team type: improvement Indicates updates or improvements on existing features labels Mar 11, 2024
@github-actions GitHub Actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4644-ki24f765kq-no.a.run.app

@davidberenstein1957
Copy link
Member

@frascuchon do we test if this works when we load data form the Hub again?

@codecov Codecov
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (5f4b980) to head (457c7e8).

Additional details and impacted files 
@@                     Coverage Diff                      @@
##           feat/span-questions-support    #4644   +/-   ##
============================================================
  Coverage                        89.14%   89.14%           
============================================================
  Files                              193      193           
  Lines                            11792    11794    +2     
============================================================
+ Hits                             10512    10514    +2     
  Misses                            1280     1280

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon
Copy link
Member Author

@frascuchon do we test if this works when we load data form the Hub again?

Yes. This test is taking care of that

@frascuchon frascuchon merged commit bc3f930 into feat/span-questions-support Mar 13, 2024
16 checks passed
@frascuchon frascuchon deleted the feat/apply-some-of-suggested-changes branch March 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 Awaiting requested review from davidberenstein1957

Assignees
No one assigned
Labels
area: tests Indicates that an issue or pull request is related to the tests language: python Pull requests or issues that update Python code severity: minor Indicates that the issue isn't urgent or blocking size:S This PR changes 10-29 lines, ignoring generated files. team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team type: improvement Indicates updates or improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frascuchon @davidberenstein1957