Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Azure and add GCP documentation for quickstart deployment #4576

Merged

Conversation

burtenshaw
Copy link
Contributor

@burtenshaw burtenshaw commented Feb 7, 2024

Description

This PR updates the documentation for azure and add documentation for deployment on GCP with cloud run.

Type of change

  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. type: documentation Improvements or additions to documentation labels Feb 7, 2024
@davidberenstein1957
Copy link
Member

Hi @burtenshaw, looking good but can you include the GCP part here? #4504 I think it is nice to acknowledge/review work on top of the contributor his work to acknowledge the effort he/she put into it.

Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but as mentioned we can keep the GCP improvement for here #4504

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 7, 2024
@burtenshaw burtenshaw merged commit 4e53300 into argilla-io:develop Feb 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files. type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants