-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve upsert responses bulk #4451
perf: improve upsert responses bulk #4451
Conversation
d81909a
to
be6612a
Compare
for more information, see https://pre-commit.ci
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4451-ki24f765kq-no.a.run.app |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/bulk-annotation #4451 +/- ##
============================================================
+ Coverage 66.16% 91.36% +25.19%
============================================================
Files 335 340 +5
Lines 19333 19822 +489
============================================================
+ Hits 12792 18110 +5318
+ Misses 6541 1712 -4829 ☔ View full report in Codecov by Sentry. |
Great work @frascuchon discarding 100 records. |
Description
This PR applies some performance improvements related to the bulk upsert responses endpoint since some environments are experimenting with a high execution time when running this operation with 100 items in the request.
The performance improvements are:
These improvements are applied based on the profiling results using the test ...
Also, since the current API controller is doing many things, a new design proposal is applied in the implementation by defining a simple use case implementation for this functionality. The use case wraps all the needed steps to cover the functionality and make the controller implementation quite simple, focusing only on exception handling and request/response serialization.
Closes #4449
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Test locally
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)