Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: David Berenstein <[email protected]>
  • Loading branch information
frascuchon and davidberenstein1957 authored Jun 3, 2024
1 parent 9d561f2 commit 6c37f87
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/argilla_sdk/settings/_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -366,23 +366,23 @@ def _upsert_fields(self) -> None:
field.dataset = self.dataset
field.update() if field.id else field.create()
except ArgillaAPIError as e:
raise SettingsError(f"Failed to create/update field {field.name}") from e
raise SettingsError(f"Failed to create/update field {field.name} with id {field.id}") from e

def _upsert_vectors(self) -> None:
for vector in self.__vectors:
try:
vector.dataset = self.dataset
vector.update() if vector.id else vector.create()
except ArgillaAPIError as e:
raise SettingsError(f"Failed to create/update vector {vector.name}") from e
raise SettingsError(f"Failed to create/update vector {vector.name} with id {vector.id}") from e

def _upsert_metadata(self) -> None:
for metadata in self.__metadata:
try:
metadata.dataset = self.dataset
metadata.update() if metadata.id else metadata.create()
except ArgillaAPIError as e:
raise SettingsError(f"Failed to create/update metadata {metadata.name}") from e
raise SettingsError(f"Failed to create/update metadata {metadata.name} with id {metadata.id}") from e

def _validate_empty_settings(self):
if not all([self.fields, self.questions]):
Expand Down

0 comments on commit 6c37f87

Please sign in to comment.