Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read Node version from .nvmrc #2029

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

phillip-kil
Copy link

@phillip-kil phillip-kil commented May 4, 2023

Issue / feature description

This PR enables the CI to read the Node version from the .nvmrc file, so we have a deterministic environment in all pipelines and match the locally used version.

Changes

Read .nvmrc in CI workflows instead of hardcoding the Node version in multiple places.

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant