Add date autosuggest to readme; Add en-gb support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcain
force-pushed
the
chore/update-readme
branch
from
855345d
to
f2ee41e
Compare
This was
linked to
issues
Apr 30, 2021
Closed
argenos
reviewed
Apr 30, 2021
|
|
||
| let date = this.parseDate(selectedText); | ||
| onTrigger(mode: string): void { | ||
| const activeView = this.app.workspace.getActiveViewOfType(MarkdownView); |
There was a problem hiding this comment.
I could have sworn I had fixed this already! Thanks ❤️
Co-authored-by: Argentina Ortega Sáinz <[email protected]>
Co-authored-by: Argentina Ortega Sáinz <[email protected]>
|
Updated. Any opinion on this comment?
(Previously the behavior was to keep autosuggest in sync with the datepicker settings.) |
|
I agree! I think it makes sense to separate these two contexts. Ready to merge? |
|
Yep, feel free to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #18
solves #30
autosuggestLinkToggleinstead of relying on the value ofmodalLinkToggle. This seemed more intuitive to me, but let me know what you think @argenosX days agoso it shows up in the autosuggest againeslintto catch all the Typescript warnings. For a smaller diff, don't look at the last commit.