Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates serpent tools dependency and pins python version #209

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

samgdotson
Copy link
Contributor

Summary of changes

This PR updates the environment.yml file by

  • pinning a version of Python that is less than 3.12
  • installing serpentTools via pip directly from GitHub, rather than PyPI.

This should fix the failing tests on GH actions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change is a source code change
    • I have added/modified tests to cover my changes
    • I have explained why my change does not require new/modified tests
  • My change is a user-facing change
    • I have recorded my changes in the changelog for the upcoming release
  • My change is exclusively related to the repository (e.g. GitHub actions workflows, PR/issue templates, etc.)
    • I have verified or justified that my change will work as intended.
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Associated Issues and PRs

  • Issue: #

Associated Developers

  • Dev: @

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@samgdotson
Copy link
Contributor Author

samgdotson commented Jan 15, 2025

@yardasol I did my best to move the needle on this... I'm not sure what testing you've done but I'm sure you're aware of the Numpy issues. I worked on it for a bit but it feels a little like whack-a-mole.

Fortunately, the error message is different. I now suspect the problem is with the installation of saltproc itself. I'm not totally sure how to tell setuptools to install a package from GitHub... I found this old documentation (which is a bit light on the documentation) suggesting something called "dependency links". But I'm not sure how much hacking you want to do with setuptools since I think it's becoming deprecated, anyway.

@yardasol
Copy link
Contributor

yardasol commented Jan 20, 2025

Thanks @samgdotson , I suspect a better solution would be to move away from setuptools to a more modern build procedure, like a pyproject.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants