updates #6
Merged
updates #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add links to our setup guideline. * Add link to PRs (to ensore that not koppors fork is used) * Fix casing
* - Added a "Compare" button for duplicate entries in the CitationRelationsTab. - Added localization key for 'Compare with duplicate entries'. * - Implemented functionality to open a "Possible duplicate entries" for comparing and merging duplicate entries. - Updated changelog for compare button feature. * Updated changelog * - Updated localization key for compare button tooltip. - Fixed bug that when adding an entry to the library from Citation Relations Tab by adding the entry's clone instead of itself. - Optimised openPossibleDuplicateEntriesWindow function in CitationRelationsTab.java to show result of undo and redo. - Implemented that After clicking "merge", the current entry will be kept selected - and not the merged entry be selected. * Modified CitationsRelationsTabViewModel and ImportHandler to pass CitationsRelationsTabViewModelTest with clone entries. * - Deleted old code in CitationRelationTab.java which to implement that original entry be selected after citation item merge. - Modified MainTable#clearAndSelect to ensure original entry be selected after citation item merge. - Added some comments. * Optimised citation relations item merge: Added a citation merge flag in MainTable.java to let original entry get selected after merge instead of selecting new merged entry. * Optimised MainTable#clearAndSelect: make the code look more concise. * Fixed bug: As original local entry of citation relation item has been changed to new merged entry, need to refresh selected citation relation item to ensure that the item link to current local entry instead of the old one. * Adapted tool tip of compare button. * - renamed some variables to make them more understandable - fixed wrong position codes: codes that updating citation relation item and setting state of citationMergeMode now be moved into CitationRelationsTab#openPossibleDuplicateEntriesWindow - modified some comments and Java doc * Move statement closer to intended use * Modified the column headings of the merge entries dialog to make them more self-explanatory. --------- Co-authored-by: Oliver Kopp <[email protected]>
* Add references to other tests * Simplify code * Add test for extracting the first word * Relax escaping * Add link to PR * Add tests Refs #11367 * Refine CHANGELOG.md * Refine CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.