do not auto-resize FS with embedded files in the firmware #19059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
At first boot after flash or resetting the boot count to 0 with
reset 99
Tasmota will try to automatically resize the filesystem partition to the maximum size.This is problematic when files are embedded in the firmware binary, because they are erased in this process which renders the whole file embedding useless.
Until now it was necessary to flash with fixed partition values to prevent this deletion.
This PR checks, if there are more files than
.settings
in path/
and will not call the resize function.This is not perfect, as we have to live with the smaller FS, but if a larger FS is needed, then another firmware (without embedded files) should be chosen anyway.
For the future it would be super nice to let the FS grow non-destructive in Tasmota or add some firmware patching magic to esptool.
@s-hadinger Please check, if there is a better solution to accomplish this.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass