Rethink the way the error handler works #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofandel
force-pushed
the
fix/error-handler
branch
3 times, most recently
from
b41b9c4 to
c62b22f
Compare
|
This is great @Tofandel thank you. The custom exception handler has definitely been a source of issues and this approach is so much better. |
ifox
reviewed
Jun 13, 2024
Tofandel
force-pushed
the
fix/error-handler
branch
from
c62b22f to
f1041d1
Compare
Tofandel
force-pushed
the
fix/error-handler
branch
from
df84398 to
d67ae26
Compare
Tofandel
force-pushed
the
fix/error-handler
branch
from
d67ae26 to
f76d55f
Compare
ifox
approved these changes
Oct 14, 2024
ifox
added a commit
that referenced
this pull request
Oct 14, 2024
With the default path set to `admin`, `/adminsomething`, eg. `/administration` would trigger the Twill 404 error instead of the frontend 404 due to the start of the path matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2607
We can use the user provided handler and simply add render cases via methods, so we don't need to provide our own exception handler, which will alleviate the need for more configuration/setup when installing twill
I also optimized the provider to have all the config in one place and not have it run if the config is already cached