Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zmk version #13

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Update zmk version #13

merged 5 commits into from
Jul 12, 2024

Conversation

anoburn
Copy link

@anoburn anoburn commented Jul 11, 2024

I changed the zmk version we use back to "main" and adapted the rest of our code to the changes. This boils down to:

Copy link
Collaborator

@mcrosson mcrosson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only one concern (see comment on the west config). Everything else looks good.

config/west.yml Outdated
@@ -7,7 +7,7 @@ manifest:
projects:
- name: zmk
remote: zmkfirmware
revision: ae8299edb3d638f1332475b1da0fdf40afa43fe4
revision: main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the version in the config to match the current 'main' so we don't run into build issues in the future and its clear exactly which version of zmk is being used for ardux builds?

@mcrosson mcrosson merged commit 1f9e79f into arduxio:main Jul 12, 2024
28 of 29 checks passed
@anoburn anoburn deleted the update-zmk-version branch July 12, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants