Client connect timeout support #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client connect timeout is very useful if the other device may be out of reach. Then the default timeout of LwIP is too long (looks like it is 18 seconds).
The PR adds the support for the timeout in WiFiNINA. The new code is only active if timeout is not 0. With timeout 0 it works like before.
The timeout version of connect is based on the code from the esp32 Arduino WiFi library, which is based on IDF examples. It looks like many lines, but it is just detailed error detection and logging which I didn't want to throw away.