Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/JohannesKaufmann/html-to-markdown from 1.4.0 to 1.4.2 in /ruledocsgen #644

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2023

Bumps github.com/JohannesKaufmann/html-to-markdown from 1.4.0 to 1.4.2.

Release notes

Sourced from github.com/JohannesKaufmann/html-to-markdown's releases.

v1.4.2

What's Changed

Full Changelog: JohannesKaufmann/html-to-markdown@v1.4.1...v1.4.2

v1.4.1

No release notes provided.

Commits
  • a5828fd Bump golang.org/x/net from 0.14.0 to 0.18.0 (#82)
  • fab894e Bump github.com/yuin/goldmark from 1.5.5 to 1.6.0 (#81)
  • bcbfd0d Bump golang.org/x/net from 0.9.0 to 0.14.0 (#74)
  • afdc7df Bump github.com/yuin/goldmark from 1.5.4 to 1.5.5 (#73)
  • 2273319 updated logo
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (868c6cc) 90.05% compared to head (377f600) 90.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   90.05%   90.20%   +0.14%     
==========================================
  Files          44       43       -1     
  Lines        6800     6638     -162     
==========================================
- Hits         6124     5988     -136     
+ Misses        553      536      -17     
+ Partials      123      114       -9     
Flag Coverage Δ
unit 90.20% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error is exposed by the CI system:

# golang.org/x/net/http2
Error: ../../../../go/pkg/mod/golang.org/x/[email protected]/http2/transport.go:1021:13: tc.NetConn undefined (type *tls.Conn has no field or method NetConn)
note: module requires Go 1.18

I guess this is caused by golang.org/x/[email protected] having a minimum compatibility of Go 1.18 while this project currently uses go1.17.

So merging of this PR must be put on hold until we are able to find time to update the project to using a newer version of Go.

@per1234 per1234 added the status: on hold Do not proceed at this time label Dec 7, 2023
@dependabot dependabot bot force-pushed the dependabot/go_modules/ruledocsgen/github.com/JohannesKaufmann/html-to-markdown-1.4.2 branch 2 times, most recently from 377f600 to 8688d2f Compare December 8, 2023 08:42
Bumps [github.com/JohannesKaufmann/html-to-markdown](https://github.com/JohannesKaufmann/html-to-markdown) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/JohannesKaufmann/html-to-markdown/releases)
- [Commits](JohannesKaufmann/html-to-markdown@v1.4.0...v1.4.2)

---
updated-dependencies:
- dependency-name: github.com/JohannesKaufmann/html-to-markdown
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/ruledocsgen/github.com/JohannesKaufmann/html-to-markdown-1.4.2 branch from 8688d2f to 625f4ce Compare December 19, 2023 17:39
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 28, 2023

Superseded by #674.

@dependabot dependabot bot closed this Dec 28, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/ruledocsgen/github.com/JohannesKaufmann/html-to-markdown-1.4.2 branch December 28, 2023 05:33
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted status: on hold Do not proceed at this time topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants