Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform aware CLI config resolution #197

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

artis101
Copy link

@artis101 artis101 commented Oct 30, 2024

  • What kind of change does this PR introduce?
    This is a bug fix for ArduinoCLI config file path resolution under Darwin platform. CLI config path resolution was moved from main into a separate utility package.
  • What is the current behavior?
    arduino-language-server fails on OS X with the following error message:
ArduinoCLI config file found at /Users/$USER/.arduino15/arduino-cli.yaml

On OS X ArduinoCLI installs configuration files to /Users/$USER/Library/Arduino15/arduino-cli.yaml
On Windows in %LOCALAPPDATA%/Arduino15 (i.e., C:/Users//AppData/Local/Arduino15/arduino-cli.yaml)

  • What is the new behavior?
    Paths are now correctly resolved based on Go OS.

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024

CLA assistant check
All committers have signed the CLA.

@artis101 artis101 force-pushed the platform_aware_cli_config_resolution branch from 8d7b6bb to b2c8536 Compare October 30, 2024 12:37
utils/path.go Show resolved Hide resolved
@per1234 per1234 added os: windows Specific to Windows operating system os: macos Specific to macOS operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 30, 2024
@artis101 artis101 requested a review from per1234 October 30, 2024 15:15
@artis101 artis101 changed the title Add platform/darwin aware CLI config resolution Add platform aware CLI config resolution Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macos Specific to macOS operating system os: windows Specific to Windows operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants